fix: Customize ScrollPhysics for MonthView #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thView This allows passing in for example NeverScrollableScrollPhysics to avoid vertical scrolling
* master: feat: Added a callback for the default header title for all view SimformSolutionsPvtLtd#241. fix: 🐛Day view auto scroll to initial duration when using [scrollOffset] & [startingDuration] SimformSolutionsPvtLtd#269. Fixed issue with overlapping events formatted changes Updated default hourLineBuilder Updated Docs Fixed horizontal offset Added custom hour line painter functionality
|
This might solve #178 as well |
dumazy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows for adding a specific
ScrollPhysicsto the month view, for the month view's pages.In my case, I have the
MonthViewnested somewhere in a sliver of aCustomScrollViewand the month view page'sGridViewsuddenly takes the "scroll focus" while I just want it never to scroll. This option allows me to pass in aNeverScrollableScrollPhysicswhich fixes the issue.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
No breaking changes
Migration instructions
If the PR is breaking, uncomment this header and add instructions for how to migrate from the
currently released version to the new proposed way.
-->
Fixes #178